Add nomination issue template #23

jtojnar · 2025-08-13T08:00:39Z

A new, more organized way to nominate Nixpkgs committers.

https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-templates

Adds links to contact options when creating a new issue. https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser

A new, more organized way to nominate Nixpkgs committers. https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-templates

jtojnar · 2025-08-13T08:03:22Z

Will want to set up CI to notify #50

wolfgangwalther

IIRC, there were some commands that people are running nowadays to get the respective links to "reviewed PRs", "authored PRs" etc.

Maybe provide these commands in the PR template as a base? Or would these be filled by CI somehow?

wolfgangwalther · 2025-08-13T10:31:40Z

.github/ISSUE_TEMPLATE/01_nomination.yml

+  - type: markdown
+    attributes:
+      value: |
+        Thanks for taking the time to fill out this bug report!


bug report is wrong, I think.

SigmaSquadron

I do apologise if we shouldn't review this yet, as it's a draft, but there are some things I learned while making the YAML forms for Nixpkgs that may be helpful here too.

SigmaSquadron · 2025-08-13T10:45:59Z

.github/ISSUE_TEMPLATE/01_nomination.yml

@@ -0,0 +1,25 @@
+name: Committer Nomination
+description: Nominate a user for Nixpkgs commit access.
+title: "[Nomination]: "


Suggested change

title: "[Nomination]: "

title: "[Nomination]: NAME"

We have placeholders like PACKAGENAME in Nixpkgs, and they usually work like 95% of the time. Since the only people being nominated here are supposed to be reasonably proficient with Nixpkgs' workflow, I think everyone will manage to replace it.

SigmaSquadron · 2025-08-13T10:47:25Z

.github/ISSUE_TEMPLATE/01_nomination.yml

@@ -0,0 +1,25 @@
+name: Committer Nomination
+description: Nominate a user for Nixpkgs commit access.


This wording seems to imply that self-nominations will no longer be allowed? Will there be a separate issue template for self-nominations? Are they outright banned?

I don't get that from the wording, just says you're nominating a singular user.

SigmaSquadron · 2025-08-13T10:51:15Z

.github/ISSUE_TEMPLATE/01_nomination.yml

+labels: ["nomination"]
+assignees:
+  - @NixOS/commit-bit-delegation
+body:


I would highly recommend adding a markdown item as the first form component that explains in more detail what this is all for. See the Nixpkgs bug report template for reference.

SigmaSquadron · 2025-08-13T10:55:03Z

.github/ISSUE_TEMPLATE/01_nomination.yml

+      label: GitHub user name
+      placeholder: octocat


Suggested change

label: GitHub user name

placeholder: octocat

label: GitHub Username

description: The GitHub username currently used by the committer nominee.

In Nixpkgs, we removed placeholders in order to reduce the overall information density. I would recommend doing the same here and using descriptions instead.

NixOS/nixpkgs#368656 (review)

SigmaSquadron · 2025-08-13T11:00:36Z

.github/ISSUE_TEMPLATE/01_nomination.yml

+  - type: textarea
+    id: reason
+    attributes:
+      label: Reason
+      description: Why I are you nominating this person? Please include links to their relevant PR and reviewing activity.
+    validations:
+      required: true


I feel like we can split this up into a few more questions. Most nominations in the old issue follow mostly the same format (sometimes the first and second paragraph are flipped):

First paragraph introduces the person and shows something notable that they have done. This is usually a large NixOS module or something equally impactful.

Second paragraph usually mentions how long the person has been contributing for, and what their merged/reviewed PR stats are. (unless the stats are at the bottom of the post)

Third paragraph is usually the actual reason why the person should be a committer.

I think splitting this question appropriately will allow the delegation team to more efficiently review nominations, as they would have a very similar format to each other.

SigmaSquadron · 2025-08-13T11:01:19Z

.github/ISSUE_TEMPLATE/config.yml

+  - name: Contact the Committer Delegation Team via group message on Discourse
+    url: https://discourse.nixos.org/g/nixpkgs-nominations
+    about: For private inquiries and suggestions.


This feels a bit redundant since the Discourse link is also available from the documentation below.

khaneliman · 2025-08-15T05:02:51Z

.github/ISSUE_TEMPLATE/01_nomination.yml

+    id: reason
+    attributes:
+      label: Reason
+      description: Why I are you nominating this person? Please include links to their relevant PR and reviewing activity.


Suggested change

description: Why I are you nominating this person? Please include links to their relevant PR and reviewing activity.

description: Why are you nominating this person? Please include links to their relevant PR and reviewing activity.

philiptaron · 2025-08-28T22:59:34Z

NixOS/nixpkgs#368656 is the PR (significant!) that @SigmaSquadron authored to successfully convert over Nixpkgs issues to templates. His feedback is really informed and wise!

I want to say a few things with this PR:

It's excellent that we're going to use this repository to track things. Way to go @NixOS/commit-bit-delegation team.
Making an issue per person nominated is obviously the right thing to do.
This is the place to outline the norms of what it means to be a nixpkgs contributor.
This is also the place to welcome people to that next echelon of responsibility.
This is also the place to coach people forward through time til they hit the mark!
I can't wait for this to get merged so that we can direct folks to it. It's going to be a massive upgrade on the drama-ridden main issue in Nixpkgs.

infinisil · 2025-09-18T00:42:57Z

I'd like to help out with getting this across the finish line, but I believe this should actually be done using PRs instead of issues, because

A PR can be merged and implemented directly, instead of having to manually create a PR to add the person, or adding them to the committers and waiting up to 24 hours for CI to run the daily sync
A PR can easily be approved by individual commit delegators (if they wish to use such a process), which gives more transparency and accountability. It also means that the team doesn't need its own internal synchronisation.

While PR templates don't support the same interactive forms that issue templates do, I don't think we benefit a lot from such issue templates for this anyways, because it's mostly free-form, and any more guided questions we might want to ask don't make a lot of sense to ask for non-self-nominations (e.g. introduce yourself, what do you plan to use commit access for, what are your conflicts of interest, ...).

While there would be a small annoyance if the committer addition would have to be entered manually because of #31, I just opened NixOS/nixpkgs#33 to avoid having to do that. This then makes it as simple as linking to https://github.com/NixOS/nixpkgs-committers/new/main/members?filename=GITHUB_HANDLE for nominations.

philiptaron · 2025-09-18T13:43:45Z

A PR can easily be approved by individual commit delegators (if they wish to use such a process), which gives more transparency and accountability. It also means that the team doesn't need its own internal synchronization.

For me, point 2 trumps every other one, since it makes the acceptance process both transparent and asynchronous. Since issues cannot be accepted, only commented on, the UI is just worse by default.

I do note that we could hack issues to get what we want, primarily with labels, so that each member of the commit bit team gets their own "✅" and "❌" label they can use on the issue. While it's not as clear as the acceptance from a PR, it's not a complete blocker either.

The downside, in my view, is that most of the "stuff" for a PR -- the code most especially -- isn't relevant for the nomination. So there's a bunch of functionality that has be ignored.

MattSturgeon · 2025-09-18T20:32:44Z

The downside, in my view, is that most of the "stuff" for a PR -- the code most especially -- isn't relevant for the nomination. So there's a bunch of functionality that has be ignored.

IIRC, there were some commands that people are running nowadays to get the respective links to "reviewed PRs", "authored PRs" etc.

Maybe we can kill two birds with one stone here, and provide a small tool for getting these basic stats, opening a PR creating the relevant file, and auto-filling the title and body.

Presumably, this would be simplest as a small wrapper around the gh tool; ideally designed in such a way that users don't need to manually fork, clone, edit, etc.

I'm imagining something like nix run nixpkgs#nominate-comitter -- UserNameHere or nix-shell -p nominate-committer --run 'nominate UserNameHere'.

pbsds · 2025-09-18T21:22:07Z

I see no need to distribute such a niche tool with nixpkgs when nix run github:nixos/nixpkgs-committers#nominate will suffice

winterqt · 2025-09-18T21:49:00Z

(I'm sure it was just an example! Obviously it can live here. :))

I have thoughts about this, I'll take some time to type them up this weekend.

infinisil · 2025-09-22T15:25:23Z

I'd rather not introduce tools for something like this, that seems like over-engineering. If we want to get contributor stats automatically we can just have a GitHub action workflow run them and post it as a comment.

infinisil · 2025-09-22T19:53:22Z

I'm proposing a PR-based workflow here as an alternative: #34

wolfgangwalther · 2025-09-27T13:40:19Z

Superseded by NixOS/nixpkgs#34.

jtojnar added 2 commits August 13, 2025 09:50

Add issue template config

26fff25

Adds links to contact options when creating a new issue. https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser

Add nomination issue template

3c50152

A new, more organized way to nominate Nixpkgs committers. https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-templates

jtojnar marked this pull request as ready for review August 13, 2025 08:02

jtojnar requested a review from a team August 13, 2025 08:02

jtojnar marked this pull request as draft August 13, 2025 08:03

wolfgangwalther reviewed Aug 13, 2025

View reviewed changes

SigmaSquadron reviewed Aug 13, 2025

View reviewed changes

khaneliman reviewed Aug 15, 2025

View reviewed changes

This was referenced Sep 22, 2025

Track committer additions with git history #33

Merged

Switch to PR-based process #34

Merged

wolfgangwalther closed this Sep 27, 2025

wolfgangwalther deleted the wip/jtojnar/committer-nominations branch September 27, 2025 13:40

		@@ -0,0 +1,25 @@
		name: Committer Nomination
		description: Nominate a user for Nixpkgs commit access.

	description: Why I are you nominating this person? Please include links to their relevant PR and reviewing activity.
	description: Why are you nominating this person? Please include links to their relevant PR and reviewing activity.

Uh oh!

Add nomination issue template #23

Add nomination issue template #23

Uh oh!

Conversation

jtojnar commented Aug 13, 2025

Uh oh!

jtojnar commented Aug 13, 2025

Uh oh!

wolfgangwalther left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SigmaSquadron left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

philiptaron commented Aug 28, 2025

Uh oh!

infinisil commented Sep 18, 2025

Uh oh!

philiptaron commented Sep 18, 2025

Uh oh!

MattSturgeon commented Sep 18, 2025

Uh oh!

pbsds commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

winterqt commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

infinisil commented Sep 22, 2025

Uh oh!

infinisil commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wolfgangwalther commented Sep 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

pbsds commented Sep 18, 2025 •

edited

Loading

winterqt commented Sep 18, 2025 •

edited

Loading

infinisil commented Sep 22, 2025 •

edited

Loading